fix: fix edge case error handling on ie 11 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Nov 17, 2020
| let mpd; | ||
|
|
||
| try { | ||
| xml = parser.parseFromString(manifestString, 'application/xml'); |
There was a problem hiding this comment.
IE 11 throws on invalid xml - which isn't illogical - it's just not the error that we want to throw. We want our custom DASH_INVALID_XML error.
brandonocasey
commented
Nov 17, 2020
| @@ -6,6 +6,10 @@ export const merge = (...objects) => { | |||
|
|
|||
| return objects.reduce((result, source) => { | |||
|
|
|||
| if (typeof source !== 'object') { | |||
There was a problem hiding this comment.
IE11 doesn't like when you call Object.keys on a non-object.
gkatsev
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we never set up browserstack for this project so we only ever tested on chrome/firefox/nodejs. With the switch to github ci in #111 ie 11 started to fail.